Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: compound slots with variants #118

Merged
merged 1 commit into from
Oct 24, 2023
Merged

fix: compound slots with variants #118

merged 1 commit into from
Oct 24, 2023

Conversation

jrgarciadev
Copy link
Member

Description

Compound slots fixed, compound slots applied even when the variant was undefined or did not match

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Follow the Style Guide.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).

@jrgarciadev jrgarciadev merged commit a97aa84 into main Oct 24, 2023
4 checks passed
@mskelton mskelton deleted the fix/compound-slots branch October 24, 2023 12:40
@mskelton mskelton mentioned this pull request Oct 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jrgarciadev